Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Popper] Expose the sx prop #31833

Merged
merged 4 commits into from
Mar 21, 2022

Conversation

ivan-ngchakming
Copy link
Contributor

Modified material Popper with default styled-component (so that the consumer can pass sx prop to it).

closes #29604

@ivan-ngchakming ivan-ngchakming changed the title Popper/material expose sx prop [Popper] material expose sx prop Mar 16, 2022
@mui-bot
Copy link

mui-bot commented Mar 16, 2022

Details of bundle changes

Generated by 🚫 dangerJS against eada4f9

@danilo-leal danilo-leal changed the title [Popper] material expose sx prop [Popper] Expose the sx prop Mar 16, 2022
@danilo-leal danilo-leal added package: system Specific to @mui/system component: Popper The React component. See <Popup> for the latest version. labels Mar 16, 2022
Copy link
Member

@hbjORbj hbjORbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your contribution! It looks good to me except the 1 comment I left.

@ivan-ngchakming ivan-ngchakming requested a review from hbjORbj March 17, 2022 11:40
@hbjORbj hbjORbj force-pushed the popper/material-expose-sx-prop branch from a4c3dd0 to eada4f9 Compare March 18, 2022 11:23
@ivan-ngchakming
Copy link
Contributor Author

@hbjORbj I guess everything is good to go then? Anyway thanks a lot for guiding me through this (my first time contributing to open source haha).

I actually want to keep contributing more to the project, I am looking at issue 27170 (Unstyled components progress), seems like something I'd be interested in working on, but I am having trouble deciding which to work on. Any advice on which component I should take (or any other issues I should work on) that's relatively easier?

@michaldudak
Copy link
Member

Hey @ivan-ngchakming, let me chime in here. I'm glad you'd like to help with the unstyled components. We haven't prioritized the remaining ones yet, but likely we will like to focus on the remaining form controls first (checkbox, radio button). However, they may be a bit tricky to finish if you're new to contributing.

Alternatively, you can tackle some bugs in the existing components - this work is equally important. See https://github.com/mui/material-ui/issues?q=is%3Aopen+is%3Aissue+label%3A%22package%3A+base%22+-label%3Aumbrella+-label%3Adiscussion for the list of known issues in unstyled components and take one that hasn't been claimed by anyone yet. I'll happily provide assistance if needed.

@hbjORbj hbjORbj merged commit c843845 into mui:master Mar 21, 2022
@ivan-ngchakming ivan-ngchakming deleted the popper/material-expose-sx-prop branch March 21, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Popper The React component. See <Popup> for the latest version. package: system Specific to @mui/system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Popper] Material/Joy exposing sx prop?
5 participants