-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Popper] Expose the sx
prop
#31833
[Popper] Expose the sx
prop
#31833
Conversation
sx
prop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for your contribution! It looks good to me except the 1 comment I left.
a4c3dd0
to
eada4f9
Compare
@hbjORbj I guess everything is good to go then? Anyway thanks a lot for guiding me through this (my first time contributing to open source haha). I actually want to keep contributing more to the project, I am looking at issue 27170 (Unstyled components progress), seems like something I'd be interested in working on, but I am having trouble deciding which to work on. Any advice on which component I should take (or any other issues I should work on) that's relatively easier? |
Hey @ivan-ngchakming, let me chime in here. I'm glad you'd like to help with the unstyled components. We haven't prioritized the remaining ones yet, but likely we will like to focus on the remaining form controls first (checkbox, radio button). However, they may be a bit tricky to finish if you're new to contributing. Alternatively, you can tackle some bugs in the existing components - this work is equally important. See https://github.com/mui/material-ui/issues?q=is%3Aopen+is%3Aissue+label%3A%22package%3A+base%22+-label%3Aumbrella+-label%3Adiscussion for the list of known issues in unstyled components and take one that hasn't been claimed by anyone yet. I'll happily provide assistance if needed. |
Modified material Popper with default styled-component (so that the consumer can pass sx prop to it).
closes #29604